search

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.2k stars 868 forks source link

NodeInstaller is not copying the npm binaries next to the node exec #1152

Open ia3andy opened 3 weeks ago

ia3andy commented 3 weeks ago

This causes package.json script using npm to yield: npm command not found, because it is not in the PATH.

There is a comment saying it does, but it's is not actually done: https://github.com/eirslett/frontend-maven-plugin/blob/master/frontend-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeInstaller.java#L192

It works when using the NPMInstaller because it actually does it: https://github.com/eirslett/frontend-maven-plugin/blob/master/frontend-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NPMInstaller.java#L182-L205