search

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.26k stars 872 forks source link

Plugin Downloads x86 Version of node on aarch64 #1154

Open suddendust opened 5 months ago

suddendust commented 5 months ago

Do you want to request a feature or report a bug? bug

What is the current behavior? I have a dependency on frontend-maven-plugin in my application which is defined as:

      <plugin>
        <groupId>com.github.eirslett</groupId>
        <artifactId>frontend-maven-plugin</artifactId>
        <version>1.15.0</version>
      </plugin>

I am doing a maven build with the following command: mvn clean install -Dcheckstyle.skip -Dlicense.skip -Dmaven.test.skip=true -Dos.arch=aarch_64 -Pbin-dist -T 1C -U

The build is failing as the plugin seems to be downloading the x86 binary:

[INFO] Downloading https://nodejs.org/dist/v16.15.0/node-v16.15.0-linux-x64.tar.gz to /root/.m2/repository/com/github/eirslett/node/16.15.0/node-16.15.0-linux-x64.tar.gz

[INFO] Running 'npm ci' in /home/pinot/pinot/pinot-controller/src/main/resources
[INFO] /home/pinot/pinot/pinot-controller/target/node/node: 1: ELF: not found
[INFO] /home/pinot/pinot/pinot-controller/target/node/node: 2: Syntax error: word unexpected (expecting ")")

If the current behavior is a bug, please provide the steps to reproduce. Checkout https://github.com/apache/pinot on an arm64 machine and run the command above.

What is the expected behavior? It should download the correct node executable for arm64.

Please mention your frontend-maven-plugin and operating system version. OS: linux-aarch65 Plugin version: 1.15.0

suddendust commented 5 months ago

There was an earlier issue on this but it was closed without a resolution: https://github.com/eirslett/frontend-maven-plugin/issues/884

mamccorm commented 1 month ago

+1 for a resolution here