search

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.26k stars 870 forks source link

Copying npm scripts for embedded node #868

Closed mwatts15 closed 4 years ago

mwatts15 commented 4 years ago

Summary If the "provided" npm version is used, the binaries are not copied into the node directory so they aren't in the path for npm executions started from the plugin. For example, the prebuild in the example project calls npm install which will use the system npm rather than that installed for the porject. This is experienced by reporters of #458 and #860.

Tests and Documentation Modified existing node-provided-npm integration test.

The example test is failing due to some phantomjs error and is apparently unrelated.

eirslett commented 4 years ago

Looks good to me, thanks! I guess it'll be in the christmas release! :-D

eirslett commented 4 years ago

There we go, 1.9.0 is released, merry christmas! 🎅 ❄️ 🎄