search

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.26k stars 870 forks source link

Fix JavaDoc build failures on JDK 11 by setting source to 1.8 #870

Closed famod closed 4 years ago

famod commented 4 years ago

Summary

Fixes:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:jar (attach-javadocs) on project frontend-plugin-core: MavenReportException: Error while generating Javadoc:
[ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.

Also adds explicit maven-deploy-plugin version to get rid of nagging warning banner.

Tests and Documentation

n/a

famod commented 4 years ago

Please note that after merging this PR other PRs will most likely need to be rebased/updated so that new builds are triggered.

eirslett commented 4 years ago

Thanks!! :heart: