search

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.23k stars 867 forks source link

Fix testFailureIgnore config in readme #903

Closed tarioch closed 4 years ago

tarioch commented 4 years ago

Summary Readme is wrong about the config option for enabling/disabling test failure ignore setting. The config is different from the property name.

eirslett commented 4 years ago

Are you sure they're not mapped to the same property?

eirslett commented 4 years ago

It's like this in the source code:

    @Parameter(property = "maven.test.failure.ignore", defaultValue = "false")
    protected boolean testFailureIgnore;
tarioch commented 4 years ago

This is about the config not the property.

eirslett commented 4 years ago

ah ok! Thanks for clearing it up!