eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.25k stars 871 forks source link

Download appropriate node/npm binaries for platform #904

Open ghost opened 4 years ago

ghost commented 4 years ago

Do you want to request a feature or report a bug? Both

What is the current behavior? Incorrect binaries downloaded on musl-libc based Linux distros.

If the current behavior is a bug, please provide the steps to reproduce. Try building a project on Alpine or Busybox.

What is the expected behavior? Successful build.

Please mention your frontend-maven-plugin and operating system version. Affects all versions of the plugin as of right now. Applies to all musl-libc Linux distros.

ghost commented 4 years ago

At minimum, the documentation should state that the plugin is platform dependent and requires Linux distros with glibc. Ideally, it would be nice if it checked and downloaded the right binaries.