search

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.23k stars 867 forks source link

Adding serverId documentation to authenticate on node download #916

Closed froblesmartin closed 4 years ago

froblesmartin commented 4 years ago

Summary

I needed to authenticate when downloading Node and couldn't find how to do it reading the documentation. Finally through google I found this issue where the 2nd message pointed me to the right direction: https://github.com/eirslett/frontend-maven-plugin/issues/410

As we can see in this PR: https://github.com/eirslett/frontend-maven-plugin/pull/390, it enabled to specify a server ID from the Maven settings, but this was not explained in the README.md.

Tests and Documentation

No required as it is just an improvement on the README.md

froblesmartin commented 4 years ago

@eirslett whenever you can, please have a look into this easy PR 😄

Thank you!

eirslett commented 4 years ago

Ah thanks!