eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.23k stars 867 forks source link

No Proxy Settings from settings.xml in wrong format #918

Closed tkalmar closed 4 years ago

tkalmar commented 4 years ago

Do you want to request a feature or report a bug? Report a Bug.

What is the current behavior? in settings.xml are nonProxyHosts defined according to http://maven.apache.org/guides/mini/guide-proxies.html

npm is called with --noproxy=localhost|127.0.0.1|192.* The npm documentation https://docs.npmjs.com/misc/config#noproxy states A comma-separated string or an array of domain extensions that a proxy should not be used for. So both formats are not directly interchangeable.

If the current behavior is a bug, please provide the steps to reproduce. Have nonProxyHosts set in your settings.xml with multiple hosts

What is the expected behavior? a correct noproxy parameter for npm

Please mention your frontend-maven-plugin and operating system version. Win 10 1904, frontend-maven-plugin:1.10.0

tkalmar commented 4 years ago

cc @famod