Fixes #634 pnpm integration.

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.

Apache License 2.0

4.23k stars 867 forks source link

Fixes #634 pnpm integration. #927

Closed bmarwell closed 3 years ago

bmarwell commented 4 years ago

Summary

PNPM support as requested in https://github.com/eirslett/frontend-maven-plugin/issues/634

Tests and Documentation

integration test created
Can update CHANGELOG.md and add some infos to README.md if requested. PRs to my PR-Branch are welcome.

bmarwell commented 3 years ago

@eirslett PTAL

bmarwell commented 3 years ago

@noblica PTAL. Also, please execute mvn clean verify -PintegrationTests. It downloads phantomjs, but German provider Telekom has only 200bytes/s at the moment to github/AWS servers.

bmarwell commented 3 years ago

@noblica @eirslett any chance for this getting merged?

noblica commented 3 years ago

@noblica @eirslett any chance for this getting merged?

Hey, I'm not a maintainer or anything (just a javascript guy). So it's really up to @eirslett .

bmarwell commented 3 years ago

@karlvr @eirslett @noblica rebased for the third time and fixed two more npm occurances.

eirslett commented 3 years ago

Sorry for the late response! I've been reluctant to add pnpm support, because this plugin already supports everything but the kitchen sink, and I would prefer not to add any more complexity. However, pnpm is quite persistently being requested, so let's make an exception. I'll go ahead and release this. Thanks for the contribution!

alexiuscrow commented 1 month ago

Hello guys. Currently, the README doesn't contain any mentions of pnpm. Is there a how-to guide?