search

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.23k stars 867 forks source link

Supports Alpine by detecting OS using /etc/alpine-release #934

Closed codefromthecrypt closed 3 years ago

codefromthecrypt commented 3 years ago

Summary

Alpine is a small OS distribution that supports JDK. Supporting Alpine means less download time and cost when building projects in Docker.

This solves the same problem #853 did, via a different approach.

The above changes allow someone to override the download root regardless of if the nodejs dist is experimental or not.

Tests and Documentation

This backfills tests for Platform using the same approach as we do in Brave (powermock).

codefromthecrypt commented 3 years ago

testing manually here (our builder image is alpine) https://github.com/openzipkin/zipkin/compare/DO_NOT_MERGE_test-frontend-maven-plugin

codefromthecrypt commented 3 years ago

^^ works fine!

eirslett commented 3 years ago

OK, let's go with this implementation!

eirslett commented 3 years ago

There we go, it's in the 1.10.2 release.

codefromthecrypt commented 3 years ago

Thanks for the quick turnaround, @eirslett!