Fix proxy parsing - Githubissues

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.

Apache License 2.0

4.23k stars 867 forks source link

Fix proxy parsing #935

Closed tkalmar closed 3 years ago

tkalmar commented 3 years ago

Summary

After fixing the proxy parsing (replacing | with ,) a friend of mine pointed me towards: https://npm.community/t/noproxy-setting-with-more-than-one-hostname/5054/3 So the comma separated String seems not to work from commandline. Hence this fix adds an extra parameter for every proxy exclusion. I also noted that the npm documentation not mentions wildcards (seems to be a java thingy), so they are also removed when parsing the proxy settings.

Tests and Documentation

mickroll commented 3 years ago

Please integrate as soon as possible, we really depend on working proxy configuration.

eirslett commented 3 years ago

Ok, I guess it looks good!