search

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.22k stars 868 forks source link

Add m2e support for npm, npx and yarn goals #955

Open zraexy opened 3 years ago

zraexy commented 3 years ago

Summary

Adds support for running scripts when source files change without having to bump the package.json

My specific use case is automatically rebuilding an Angular frontend when its source is modified.

Theoretically the common functionality between EmberMojo, GruntMojo, GulpMojo, NpmMojo, NpxMojo, WebpackMojo, and YarnMojo could be factored out into a new class, but for now I've only endeavored to make their behavior consistent.

Resolves #932 Fixes #329, Closes #682 (included)

Tests and Documentation

Tests passed. (Not that there is coverage anyway.)

Updated CHANGELOG.md and README.md I can update the Wiki on merge.

OLibutzki commented 3 years ago

@zraexy thanks for providing this PR. What about the failed check?

zraexy commented 3 years ago

@zraexy thanks for providing this PR. What about the failed check?

It is a known issue with maven-plugin-plugin 3.2 which was fixed in 3.2.2. For whatever reason 3.2.2 doesn't appear to be in Maven Central. I'm not sure why this is only now presenting. I've made a few tweaks and added a commit bumping it to 3.3.