search

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.22k stars 868 forks source link

Support arm64 binaries since Node.js v16 #970

Closed seregamorph closed 3 years ago

seregamorph commented 3 years ago

Summary Node.js supports native arm64 binary release since v16: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V16.md#toolchain-and-compiler-upgrades For example, you can see darwin-arm64 releases here: https://nodejs.org/download/release/v16.0.0/

Old logic: for mac arm64 always prefer x64 instead. New logic: for mac arm64 prefer arm64 since node v16, otherwise fallback to old behavior.

seregamorph commented 3 years ago

@ajthom90 please check this change also

Proof of new logic. Tested on Apple M1 machine:

For node v16.1.0 - darwin-arm64:

[INFO] --- frontend-maven-plugin:1.11.4-SNAPSHOT:install-node-and-npm (install node and npm) @ webservice ---
[INFO] Installing node version v16.1.0
[INFO] Downloading https://nodejs.org/dist/v16.1.0/node-v16.1.0-darwin-arm64.tar.gz to /Users/morph/.m2/repository/com/github/eirslett/node/16.1.0/node-16.1.0-darwin-arm64.tar.gz
[INFO] No proxies configured
[INFO] No proxy was configured, downloading directly
[INFO] Unpacking /Users/morph/.m2/repository/com/github/eirslett/node/16.1.0/node-16.1.0-darwin-arm64.tar.gz into /Users/morph/Projects/acme/webservice/node/tmp
[INFO] Copying node binary from /Users/morph/Projects/acme/webservice/node/tmp/node-v16.1.0-darwin-arm64/bin/node to /Users/morph/Projects/acme/webservice/node/node

Exactly the same project, but with node version v12.14.0 - darwin-x64 fallback:

[INFO] --- frontend-maven-plugin:1.11.4-SNAPSHOT:install-node-and-npm (install node and npm) @ webservice ---
[INFO] Installing node version v12.14.0
[INFO] Downloading https://nodejs.org/dist/v12.14.0/node-v12.14.0-darwin-x64.tar.gz to /Users/morph/.m2/repository/com/github/eirslett/node/12.14.0/node-12.14.0-darwin-x64.tar.gz
[INFO] No proxies configured
[INFO] No proxy was configured, downloading directly
[INFO] Unpacking /Users/morph/.m2/repository/com/github/eirslett/node/12.14.0/node-12.14.0-darwin-x64.tar.gz into /Users/morph/Projects/acme/webservice/node/tmp
[INFO] Copying node binary from /Users/morph/Projects/acme/webservice/node/tmp/node-v12.14.0-darwin-x64/bin/node to /Users/morph/Projects/acme/webservice/node/node
ajthom90 commented 3 years ago

@seregamorph This looks great to me. I was working on this last week and got a little sidetracked (and I cancelled my MacStadium subscription, so I didn't have an M1 Mac to test it on), but my logic looks almost identical to yours. And your code looks much cleaner than mine. Thanks for taking care of this!

This idea just popped into my head though and maybe necessarily doesn't need to be done in this PR (or ever be done), but would we possibly want a config option for Mac users to say "I always want the x64 binary" even if they are on an M1 Mac? I'd assume that most people would want to run Node natively when they're on an arm64 machine, but maybe just in case people want the option? I'm good either way, like I said, it just popped into my head, so I figured I'd bring it up here.

Thanks again!

seregamorph commented 3 years ago

@ajthom90 I had the same idea. IMHO it'll be better to introduce such enhancement in next major release. Right now user can choose of three possible strategies (old, fixed by you and fixed by me) and it should cover all cases.

ajthom90 commented 3 years ago

@seregamorph I like it. Thanks again!

eirslett commented 3 years ago

LGTM, thanks!