search

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.22k stars 868 forks source link

if upgrading, first delete the full "node" dir #994

Open jcompagner opened 3 years ago

jcompagner commented 3 years ago

when i did go from Node 16.2 to 1.6.6 it did do the update to that version (this is with npm just included, not an extra npm install)

but then weird npm-cli errors came up when i then really just first delete the "node" dir and let the plugin install node again everything was fine

if i look into:

https://github.com/eirslett/frontend-maven-plugin/blob/master/frontend-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeInstaller.java

i also don't really see a full delete first..

NpmInstaller i do see that that it first does delete stuff. But not when npm is provided by node i think it is this code:

https://github.com/eirslett/frontend-maven-plugin/blob/master/frontend-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeInstaller.java#L189

are we needing there 1 line of code that deletes first if it is there the full target dir?

MonsieurBon commented 2 years ago

I can confirm that upgrading from 14.17.0 to 16.13.1 fails when running npm install. Manually removing the node folder solves the problem. The installed npm version (8.1.2) is the same for both node versions.