search

eisbuk / EisBuk

Manage bookings for ice skating lessons
GNU Affero General Public License v3.0
0 stars 1 forks source link

Fix/bookings deadline #945

Closed ikusteu closed 5 months ago

ikusteu commented 5 months ago

Fixes #840

silviot commented 5 months ago

I just tried to extend it to let an athlete book slots in March, but I was not able to.

I set the extended booking date to March 29th for an athlete, and they were not able to book lessons in March.

ikusteu commented 5 months ago

@silviot I've extended the debug box functionality and wired in the translated strings. Could you, please, take a look and provide italian translations?

Just a reminder: we went with the existing implementation and can update (extend the allowed booking timespan) if they really need it

silviot commented 5 months ago

image I would expect the countdown to read 3d3h.

image The bookings should not be locked in this case.

image The bookings should not be locked in this case.

ikusteu commented 5 months ago

Gaah...on it!

ikusteu commented 5 months ago

@silviot

  1. If the regular deadline hadn't passed yet, it is displayed (yellow box), and only when the regular deadline had passed, but extended date hadn't, the extended date is displayed (red box). The reasoning is:

    • I'm guessing the extended date won't be provided unless the original deadline had passed
    • let's assume it was the other way around (extended date having priority) - it would be awkward to click 'Finalise' and then have the first deadline countdown displayed

  3. Well...I see nothing wrong, considering the extended date had passed two years ago 😂

silviot commented 5 months ago

@ikusteu hmmm... right. Yeah, with the correct date it works as expected. :facepalm: