search

eisen-oxid / thermit

An exciting and inspiring messenger written in Rust 🦀 ✉️
MIT License
3 stars 0 forks source link

Add a authentication method based on password and make usernames unique #19

Closed frcroth closed 3 years ago

frcroth commented 3 years ago

@sirkrypt0 I wanted to test password verification and wrote a one line function for it. Then clippy was angry because the function wasn't used. So I implemented some basic authentication.

frcroth commented 3 years ago

Also this authentication method requires the user to know the id of the account which is weird. Could be saved by making username unique. That way you could just post a username password pair to users/auth and authenticate.

sirkrypt0 commented 3 years ago

Also this authentication method requires the user to know the id of the account which is weird. Could be saved by making username unique. That way you could just post a username password pair to users/auth and authenticate.

I like making the username unique.

frcroth commented 3 years ago

I have not marked this as ready, because the auth_token is not implemented, but I think a review would be beneficial, as a lot of stuff has changed @sirkrypt0

sirkrypt0 commented 3 years ago

I have not marked this as ready, because the auth_token is not implemented, but I think a review would be beneficial, as a lot of stuff has changed @sirkrypt0

I will do so. We can also merge this already and implement auth tokens in another mr.

frcroth commented 3 years ago

Ok will merge after implementing your suggestions