eisfabian / PACEtomo

Parallel cryo electron tomography via beam image shift
GNU General Public License v3.0
27 stars 6 forks source link

Elegant fail #3

Closed shahpnmlab closed 2 years ago

shahpnmlab commented 2 years ago

Hi Fabian, We managed to collect 532 TS's in 48hrs with your script! However, I was wondering if there would be a way for the script to fail more elegantly? The specific scenario that I encountered during data collection was when the estimated IS was beyond the limit of the scope (we were shooting a 7x7 pattern)and the script just stopped. Thus, we ended up with some downtime. So the suggestion then would be, for the script to check of the IS is within range if not, skip that hole position and move on to next. Do you think this would be possible to do? Best, pranav

eisfabian commented 2 years ago

Hi Pranav,

Wow! Enjoy processing this data! I agree, this could be prevented. For now, it might help to change the imageShiftLimit to 25, but I will include a check for the IS and possibly for black images in future versions! I hope I get around to it some time soon!

Thanks for the feedback! Best, Fabian

eisfabian commented 2 years ago

Hi Pranav,

I uploaded a new version to the beta folder. It includes a check if the IS is at the SerialEM image shift limit minus wiggle room for alignment. If it is at the limit it will skip the affected branch for the rest of the acquisition. Additionally I included an optional setting to do the same for dark images. I hope this catches cases like yours but I have not extensively tested it yet!

Thanks again for your feedback! Best, Fabian

shahpnmlab commented 2 years ago

Thanks Fabian! Best, Pranav

Pranav Shah Postdoctoral Research Fellow.

Division of Structural Biology, Wellcome Trust Centre for Human Genetics, University of Oxford, Roosevelt Drive, Oxford OX3 7BN, UK

On Thu, May 26, 2022 at 2:27 AM eisfabian @.***> wrote:

Closed #3 https://github.com/eisfabian/PACEtomo/issues/3 as completed.

— Reply to this email directly, view it on GitHub https://github.com/eisfabian/PACEtomo/issues/3#event-6682255270, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIDVDVTCBDC5LJFZAJYCXW3VL3HQ3ANCNFSM5V2UPTNQ . You are receiving this because you authored the thread.Message ID: @.***>