eisop / checker-framework

Pluggable type-checking for Java
https://eisop.github.io/
Other
18 stars 18 forks source link

Order of `TypeUseLocation` enum constants #741

Open wmdietl opened 5 months ago

wmdietl commented 5 months ago

https://github.com/eisop/checker-framework/blob/ecdcabc4394ffd631132a8b327288abf0694d849/checker-qual/src/main/java/org/checkerframework/framework/qual/TypeUseLocation.java#L6 mentions that the order matters.

Go through the current ordering and make sure the ordering is meaningful. In particular, the relationship between IMPLICIT_LOWER_BOUND and TYPE_VARIABLE_USE might be confusing. See this change: https://github.com/jspecify/jspecify-reference-checker/commit/651689e9fda0dbafbd50c984e73ff2068e9fad29 from PR https://github.com/jspecify/jspecify-reference-checker/pull/175.