search

eisop / checker-framework

Pluggable type-checking for Java
https://eisop.github.io/
Other
18 stars 18 forks source link

Clarify defaulting of type variable uses #746

Closed wmdietl closed 5 months ago

wmdietl commented 5 months ago

755 will look into cleaning up the ugly hack that is needed by the Resource Leak Checker.

cpovirk commented 2 months ago

Update: The problems I had reported with this PR have apparently been fixed by some other commit, whether to here, to main-eisop in the reference-checker repo, or to (for all I know) javac or something. I discovered this while testing the reference checker with 3.42.0-eisop4.

The upgrade to 3.42.0-eisop4 will not require any changes to any of our code checked by the JSpecify reference checker (aside from adding an explicit type argument to one call, which is well below the threshold of worrying about, especially with the type-inference revamp that landed upstream on the horizon).

cpovirk commented 2 months ago

Wait, no, sorry, I confused myself again: The errors are in common.collect, and we don't have nullness checking enabled for that package in our normal builds, so I wasn't seeing them. The errors remain. I'll take things back to https://github.com/jspecify/jspecify-reference-checker/pull/178#issuecomment-2088588346.