tctl does not use --cluster flag

ric-hincapie commented 9 months ago

Code line: https://github.com/eitansuez/minitsb-rake/blob/d6e3a0df4d28dc2d2f21da39b9408602e98eaac7/Rakefile#L185

Error at rake command:

vcluster connect t1
21:06:38 done Switched active kube context to vcluster_t1_vcluster-t1_k3d-tsb-cluster
- Use `vcluster disconnect` to return to your previous kube context
- Use `kubectl get namespaces` to access the vcluster
tctl install demo     --cluster t1     --registry my-cluster-registry:5000     --admin-password admin
2023-10-19 21:06:38: waiting for ManagementPlane object to exist
Error: unknown flag: --cluster
...
rake aborted!
Command failed with status (1): [tctl install demo     --cluster t1     --r...]
/home/ubuntu/minitsb-rake/Rakefile:184:in `block in <top (required)>'
Tasks: TOP => default => deploy_scenario => install_controlplanes => install_cp_c1 => install_mp
(See full trace by running task with --trace)

Working it out. Created to keep track.

eitansuez commented 9 months ago

that doesn't make sense to me. if you run tctl install demo --help you'll see in the output under "Flags" the flag --cluster. what is your tctl version?

ric-hincapie commented 9 months ago

tctl 1.6.0 does not output the --cluster option, which confused me, and I was trying to install a 1.5.5 TSB cluster. It remains to see if by removing --cluster flag it still works for backwards compatibility.

boeboe commented 9 months ago

As discussed in slack

--cluster flag was introduced in 1.6.1 or 1.6.2... as a result we need to fallback on name=demo for older releases, otherwise we'll have name mismatches later.

On Fri, Oct 20, 2023, 03:17 Ric Hincapie @.***> wrote:

tctl 1.6.0 does not output the --cluster option, which confused me, and I was trying to install a 1.5.5 TSB cluster. It remains to see if by removing --cluster flag it still works for backwards compatibility. [image: image] https://user-images.githubusercontent.com/128402831/276791398-764b1549-e68f-4905-96bd-73c2f9a822ec.png

— Reply to this email directly, view it on GitHub https://github.com/eitansuez/minitsb-rake/issues/1#issuecomment-1771920490, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADFMTUEJFU3OYNCUS743FLYAHGKHAVCNFSM6AAAAAA6H3QDY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZRHEZDANBZGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

eitansuez / minitsb-rake

tctl does not use --cluster flag #1