eith0s / rutorrent

Automatically exported from code.google.com/p/rutorrent
0 stars 0 forks source link

Lookat plugin #848

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
This new plugin is great! Congrats Novik!
One minor issue:
I have this movie(example):
The.Movie.2013.720p.BluRay.DD5.1.x264-ReleaseGroupName
Looking this title up results correctly in (youtube example):
http://www.youtube.com/results?search_query=The+Movie+2013

If there are no dots, but spaces, eg:
The Movie 2013 720p BluRay DD5.1 x264-ReleaseGroupName
the search result is this:
http://www.youtube.com/results?search_query=The+Movie+2013+720p+BluRay+DD5+1+x26
4
As you can see it does not remove the words that conf tells it to remove..

It is a really minor glitch but I thought I should mention it in case it is not 
too difficult to fix..
Regards!

Original issue reported on code.google.com by ckana...@gmail.com on 30 Aug 2013 at 1:30

GoogleCodeExporter commented 8 years ago
Another thing I just noticed:
It applies only to imdb lookup:
The.Movie.2013 in imdb creates this search query 
http://www.imdb.com/search/title?title=The+Movie+2013 (correct) but due to 2013 
imdb returns no results. Removing the year returns the correct results.
This happens only to imdb (the same query in TMDb returns the correct result) 
so it is probably their fault. 
Just thought I should mention this, too, in case there is a workaround.

Original comment by ckana...@gmail.com on 30 Aug 2013 at 1:39

GoogleCodeExporter commented 8 years ago
LATER EDIT:
imdb is not the only one with problems when the year is used in the search 
string, I'm afraid..
Perhaps a regular expression to extract the year is also needed..

Original comment by ckana...@gmail.com on 30 Aug 2013 at 2:12

GoogleCodeExporter commented 8 years ago
1) You have a pattern part of the corresponding regexp in the plugin's 
conf.php. Try to correct it on your way.
See variable $partsToRemove.

For example, for checking spaces as dots this variable must be started as

$partsToRemove = "([ \.-]...

instead

$partsToRemove = "([\.-]...

2) Sorry, but i haven't plan to realize title stripping separately for each 
source. All sources use one implementation.

Original comment by novik65 on 30 Aug 2013 at 2:48

GoogleCodeExporter commented 8 years ago
Of course....
I wasn't suggesting to use different implementations for different sites.
I am asking to consider stripping the year for all of them, since most sites I 
tested return bad results when the year is passed in the query.... But not a 
big deal anyway!!! Thanks!!!

Original comment by ckana...@gmail.com on 30 Aug 2013 at 3:35

GoogleCodeExporter commented 8 years ago
>I am asking to consider stripping the year for all of them

For that try to replace fragment of variable

|DD5.1)

to the

|DD5.1|(19\d\d)|20[0|1]\d)

Original comment by novik65 on 30 Aug 2013 at 5:06

GoogleCodeExporter commented 8 years ago
Thanks a lot!
I was trying with something like /\d{4}\b/ and wouldn't work
(19|20)[0-9][0-9], however, did the trick..I was ready to commit it and 
realized that you had answered again.. So tried yours and works too..
But since yours works, too, I will replace mine with yours (and won't commit to 
svn, since I imagine that if you wanted this change you would have commited it 
yourself... :) )

Original comment by ckana...@gmail.com on 30 Aug 2013 at 6:40