Multiple code improvements fix 2

eivindveg / HotSUploader

JavaFX-based Replay Uploader for Heroes of the Storm

Apache License 2.0

185 stars 36 forks source link

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:S2325 - "private" methods that don't access instance data should be "static". squid:S1192 - String literals should not be duplicated. You can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=squid%3AS2325 https://dev.eclipse.org/sonar/coding_rules#q=squid%3AS1192 Please let me know if you have any questions. George Kankava

zhedar commented 8 years ago

Again this seems valid to me, although I didn't let the compiler check that. At first glance I don't see any problems.