search

eivindveg / HotSUploader

JavaFX-based Replay Uploader for Heroes of the Storm
Apache License 2.0
185 stars 36 forks source link

Stuck in match view if battlelobby files weren't cleaned up properly #159

Open emmanuelhonore opened 7 years ago

emmanuelhonore commented 7 years ago
capture d ecran 2017-04-30 a 12 53 19

HotSUploader doesn't seem to upload anymore on the last version (showing an "in game" screen event though i'm not in game anymore)

eivindveg commented 7 years ago

Does this persist if you restart the application?

zhedar commented 7 years ago

I guess this forces me to update my game and take a look at this issue. Do you have any steps to reproduce? Does this happen everytime or just a single time? And as @eivindveg asked, does the screen still show, if you restart the whole application?

Maybe they changed the temporary file behaviour with 2.0, but I highly doubt that, because it would probably affect Windows installations as well.

emmanuelhonore commented 7 years ago

it's still going on after various restarts (still stuck on the same game). I havent any step by step to reproduce the problem as it happen as soon as i installed the latest release; Reinstalling HotSUploader doesnt solve the problem either (and i did not touch the saved replay folder). I really wish i could help you more with this one but i dont know how I could, any way that i could get the logs or anything that could help solve this ?

zhedar commented 7 years ago

Just did a game and this doesn't happen for me. I'm on 10.12.4 though, but there shouldn't be any differences in my opinion.

What you could do is check the temporary game files folder which is located under /private/var/folders/d_/$$LONG_NAME_WITH_RANDOM_LETTERS$$/T/TemporaryItems/Blizzard/Hereos of the Storm/ maybe just rename that folder (so we may have a possibility to debug this later on) and check again. Maybe see if it happens again after playing a game.

emmanuelhonore commented 7 years ago

it did solve it for me thanks! (i'm still curious to know how this happened in the first place though)

zhedar commented 7 years ago

It looks like your (HotS) client didn't remove some files properly (maybe it crashed?). Maybe we should add a possibility to cancel the match screen though or show the destination of the files, maybe even offer to remove them, if they are older than 2 hours. The question is now, if this happens again after you played a game or two. Just report back, if it happens again!

emmanuelhonore commented 7 years ago

I dont remember any crash but then again i might be wrong on this one. That said i'm all for adding the possibility to cancel/exit a match screen

fwip commented 7 years ago

I am currently experiencing this bug. The other night when playing, my internet cut out, and the HotS crashed while trying to reconnect. I relaunched HotS, tried to reconnect, but the game ended before I managed to reconnect.

I'll rename the directory and I expect that'll fix it, but let me know if you want any more details.

eivindveg commented 7 years ago

Zhedar discussed this with me previously, and we agreed the fix for this problem is only loading files that are less than a certain time period long. I would assume an hour is good enough.

zhedar commented 7 years ago

I just started to implement a small fix for this issue. Probably will opt for ignoring files, which are older than an hour. I will also log if such a thing happens, but maybe we should offer a better way to inform the user about those old files and how to remove them. Maybe even just remove automatically them, if they are getting really old.

This would need a bit of testing though, because I don't want to break the functionality, if there are old battlelobby files lying around (and new ones are present).