search

eivindveg / HotSUploader

JavaFX-based Replay Uploader for Heroes of the Storm
Apache License 2.0
185 stars 36 forks source link

hotsapi.net upload support #162

Open sloonz opened 7 years ago

sloonz commented 7 years ago

Upload to hotsapi.net in addition to hotslogs.

Since hotslogs & hotsapi both use the same format for match ID, I could reuse most of the code of HotsLogsProvider and moved the common code to a new class ReplayUtils.

sloonz commented 7 years ago

Note that right now duplicate detection does not works ; see https://github.com/poma/hotsapi/issues/38

sloonz commented 7 years ago

Duplicate detection is now working

eivindveg commented 7 years ago

We currently aren't supporting multiple provider(the API does, but the application design doesn't). In the future, we do intend to solve this, but this pull request cannot be included before that.

poma commented 7 years ago

but the application design doesn't

Do you mean GUI or architecture?

eivindveg commented 7 years ago

Both. I do wish to get support for multiple providers in, but I do want to do it in a way every provider can be toggled. One thing I have been working on is a configuration panel, which would allow us to do that.

GUI design-wise, we'd also need to fiddle with the list, such as displaying icons for targets a replay has been uploaded to before it's fully uploaded and removed from the list. This shouldn't be too complex, but the former issue needs to be resolved first.

ixidion commented 7 years ago

@eivindveg thinking about helping with the integration and other necessary related tasks. Whats your vision for the UI/Settings panel?

eivindveg commented 7 years ago

I appreciate any help with the design/layout of the settings panel. I'd like to design the internal settings engine myself before it's reviewed.

eivindveg commented 7 years ago

We will be integrating this pull request in 2.2 along with multi-provider support. Keep in mind that this will result in conflicts for this pull request which will have to be resolved. To make this easier, please prepare the following information:

poma commented 7 years ago

For hotsapi:

MGatner commented 6 years ago

@eivindveg curious if you've moved ahead with multi-provider support? Working on macOS support for Hotsapi.Uploader (https://github.com/poma/Hotsapi.Uploader/issues/5) and this was linked as a possible solution.