search

eivindveg / HotSUploader

JavaFX-based Replay Uploader for Heroes of the Storm
Apache License 2.0
185 stars 36 forks source link

JodaTime dependecy is unnecessary #35

Closed zhedar closed 9 years ago

zhedar commented 9 years ago

It is only used in GitHubRelease as a member variable, which is never set until now. It may be replaced by the Java8 Date and Time API classes (see Jackson-JSR-310 datatypes) or simple java.util.Date.

Removing the dependency may also help reduce the memory footprint from Issue #3 a tiny bit.

eivindveg commented 9 years ago

It is implicitly imported and required by Amazon S3, however. I wish I could simply use the Java8 datetime API, which I personally feel is much better. I would really welcome a pull request that manually writes a valid S3 request for the HotSLogs provider.