search

eivindveg / HotSUploader

JavaFX-based Replay Uploader for Heroes of the Storm
Apache License 2.0
185 stars 36 forks source link

Fix issue #80: ReplayFileComparator should not throw exception #85

Closed minlexx closed 8 years ago

minlexx commented 8 years ago

ReplayFileComparator should not throw IllegalStateException, which caused crash on startup.

This will allow (in rare cases?) duplicate replays to appear in replays list

zhedar commented 8 years ago

Thanks for your contribution! We should be able to merge this without any complications, 'Comparator's maybe shouldn't throw exceptions anyway. The List should be able to handle similar items.

zhedar commented 8 years ago

Merging this one, since it can't break anything and was discussed in #80.

zhedar commented 8 years ago

Merge reverted, wrong target branch.