search

eizedev / AirConnect-Synology

Updated AirConnect packages for Synology NAS and Synology Router
https://github.com/philippe44/AirConnect
MIT License
320 stars 14 forks source link

[FEATURE] Own packages only for airupnp or aircast #14

Closed eizedev closed 2 years ago

eizedev commented 3 years ago

The build scripts should be extended or adapted in that individual packages are built only for airupnp or aircast. (i.e. there is one package (airconnect) for both binaries and one package only for airupnp or aircast).

Alternatively, it could be considered to include the Synology Package Manager GUI and to integrate a selection menu during installation (WIZARD_UIFILES folder) which binaries should be installed and managed (Both, airupnp, aircast).

eizedev commented 3 years ago

This will be the new selection menu during installation in the package center:

image

Gummibando commented 3 years ago

Awesome. I even didn't had to open the issue myself :)

eizedev commented 3 years ago

@Gummibando The basic integration is almost finished. I just have to adjust a few small things, then you are very welcome for testing ;)

eizedev commented 3 years ago

@Gummibando

The UI integration for selecting airupnp/aircast (or both) is now integrated in the latest release. Currently only compatible with DSM 7 and above.

It would be great, if you could test it: 0.2.50.5-20210801

Gummibando commented 3 years ago

This sound fantastic. Unfortunately, I'm not yet on DSM 7. Still have some data cleanup to do before full system backup and taking the plunge. Additionally, just two days ago I sent my streamer for servicing, not sure when it will be returned.

eizedev commented 3 years ago

No problem :) I plan to provide this change probably also for DSM 6, that should be relatively quickly achievable :). With future innovations I just have to see to what extent it is still worth it. The basic functionality will of course always remain as long as it is technically possible.

eizedev commented 3 years ago

@Gummibando

I have created a DSM6 release for testing with the UI integration (backported from the dsm7 release). Could you please test it? I do not have any DSM6 device anymore, so i cannot test it by myself.

DSM6 TEST 0.2.50.5-20210826

Thanks, René :)

Gummibando commented 3 years ago

Sorry for replying late, but I just came back from being very AFZ (away from zuhause :).

Status so far:

I can install the package and the shared folder is created. Running the package brings up two error messages, missing IP and UPNP port, respectively.

AirConnect: [15:20:46] Synology IP cannot be found! Please uninstall the package and reinstall it again! (or change SYNO_IP in "/volume1/@appstore/AirConnect/airconnect.conf")

AirConnect: [15:21:54] AIRUPNP port cannot be found! Please uninstall the package and reinstall it again (or set AIRUPNP_PORT in "/volume1/@appstore/AirConnect/airconnect.conf")!

Package can be started after manually editing the (automatically created) airconnect.conf file (adding NAS IP address, adding UPNP port number), which, as per the documentation, should actually only be relevant for DSM 7 (?). Two empty xml files are created (config.xml, config-cast.xml), meaning the player (a Naim streamer) is not discovered and not available as an AirPlay target.

After manually running airupnp -i config.xml from the DSM command line, the config.xml file is populated with data including the streamer name, so it appears the streamer is discovered properly. But it is still not available as an AirPlay target. Stopping/restarting the package in Package Center brings no change, the log file looks ok, though (no obvious errors).

A check with a Bonjour browser app (Bonjeff) shows no added airplay/raop service broadcast.

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 3 years ago

This issue was closed because it has been stalled for 5 days with no activity.

github-actions[bot] commented 3 years ago

This issue was closed because it has been stalled for 5 days with no activity.

eizedev commented 2 years ago

Sorry @Gummibando, the bot closed the issue because it was stale ;-) Thanks for your detailed report, i will check it in the next days. Do you still use DSM6?

The DSM6 release with GUI + config file was a testing release, so the documentation in the readme is therefore not up to date.

Empty config files for aircast and airupnp will be ignored. The empty files will be created by default so that they will be editable from the DSM GUI (File Station) for anybody that will not connect via SSH to the NAS.

So in general, after your changes to the config file, the DSM 6 package is running but no devices will be found?

it could be possible, that the default configuration does not allow your devices. which devices you are using? Sonos should be discovered by default. You can find more information about how to change the allowed AirPlay devices in the documentation.

In short:

For a first test, you can change the airconnect.conf configuration file and remove the Line FILTER_AIRPLAY2_DEVICES="<NULL>,S1,S3,S5,S9,S12,ZP80,ZP90,S15,ZP100,ZP120,1.0,LibreWireless". Then save the file and restart the AirConnect-Synology package in the package manager gui.

If you remove this line, all speakers that are found on your network should be found by AirConnect.

Gummibando commented 2 years ago

Exactly. Package running, no devices found. The device is a Naim streamer. Unfortunately, I have upgraded to DSM 7(.0.1) by now.

eizedev commented 2 years ago

Ok, thanks for the info. I have two other issues for the DSM6 packages that i want to implement in the upcoming weeks. I will have a look at it. For now i will close this issue since the original problem was resolved with DSM7 and you have upgrade to DSM7 now.