search

ej0cl6 / deep-active-learning

Deep Active Learning
MIT License
802 stars 184 forks source link

Is there a mistake in Deepfool implementation? #15

Closed saifullah3396 closed 2 years ago

saifullah3396 commented 2 years ago

I believe there is a mistake in this line in adversarial_deepfool.py if value_i < value_l: ri = value_i/np.linalg.norm(wi.numpy().flatten()) * wi value_l = value_i # <--- this line should be added here since otherwise,t value_i is just always the last value in the for loop?

ej0cl6 commented 2 years ago

Thanks for pointing out this. Just fixed it.