ej0cl6 / deep-active-learning

Deep Active Learning
MIT License
802 stars 184 forks source link

Error in random_sampling.py #3

Closed EveWYT closed 2 years ago

EveWYT commented 4 years ago

The query function use 'return np.random.choice(np.where(self.idxs_lb==0)[0], n)' to generate new indexes, but without 'replace=False', it cannnot generate exact 1000 indexes each iteration. To compare with other query strategies with same labeled number, it should be 'return np.random.choice(np.where(self.idxs_lb==0)[0], n, replace=False)'

ej0cl6 commented 2 years ago

We have fixed this issue. Thanks for you help!