ej52 / proxmox-scripts

MIT License
568 stars 303 forks source link

Doesn't work after reboot #106

Closed PeteEdley-EdleyIT closed 9 months ago

PeteEdley-EdleyIT commented 1 year ago

If I reboot the container or the server, then the manger is no longer running, I have to re-run wget --no-cache -qO - https://raw.githubusercontent.com/ej52/proxmox/main/lxc/nginx-proxy-manager/setup.sh | sh in order to get it running again. Once it has finished running all is ok again untill i need to reboot again.

johnnylocktang commented 1 year ago

Having the exact same error.

Service npm status says its Running.

Can only see traffic on port 3000.

ScottSucksAtProgramming commented 1 year ago

Also putting my hand up for this one. I'm really grateful for the script, and @PeteEdley-EdleyIT 's fix does work. Unfortunately I don't know enough else to troubleshoot it on my own right now.

johnnylocktang commented 1 year ago

Yeah, can confirm that too. Re-running makes it work. Will try to troubleshoot some tonight.

ScottSucksAtProgramming commented 1 year ago

Okay, I think I've fixed this for my install.

When nginx starts up it looks to create /run/nginx/nginx.pid the directory is removed completely when the container restarts and nginx can't create the file. It might be a permissions issue I don't know, I'm really new at this.

If you mkdir /run/nginx and then start the process with nginx it starts up with no issues. Screenshot 2023-04-13 at 19 29 29

I don't know what the deal with the run/ directory is, but to fix this I changed the config for nginx to create the file in /tmp/nginx/nginx.pid and now it starts up happily when I restart the container.

How I Fixed

  1. Restart the container.
  2. Edit the 3rd line in the nginx.conf for me it was /etc/nginx/nginx.conf

From:

Screenshot 2023-04-13 at 19 48 51

To: Screenshot 2023-04-13 at 19 50 40

  1. Restart the container and confirm nginx is running. Screenshot 2023-04-13 at 19 52 41
ScottSucksAtProgramming commented 1 year ago

It looks like this is due to the newest version of Nginx Proxy Manager 2.10.1 which was released about two weeks ago. I found a similar issue here.

Might be able to fix the script by pulling an older version, but if anyone updates they'll end up with the same issue. If the script can update nginx.conf that might fix it. I don't know enough right now to update the script, or figure out another solution (it looks like changing the permissions of /run is bad news bears).

dem36rus commented 1 year ago

same problem

Jamyz commented 1 year ago

Thanks @ScottSucksAtProgramming , now works with the latest. Because comeback to latest 2.9.x fail with the same error s6 timeout. But i see logs and i have lots of lines like : nginx: [emerg] bind() to 0.0.0.0:80 failed (98: Address already in use) nginx: [emerg] bind() to [::]:80 failed (98: Address already in use) nginx: [emerg] bind() to 0.0.0.0:443 failed (98: Address already in use) nginx: [emerg] bind() to [::]:443 failed (98: Address already in use) nginx: [emerg] bind() to 0.0.0.0:81 failed (98: Address already in use) nginx: [emerg] bind() to [::]:81 failed (98: Address already in use)

I dont no what is this.....

rpgdev commented 3 weeks ago

Okay, I think I've fixed this for my install.

When nginx starts up it looks to create /run/nginx/nginx.pid the directory is removed completely when the container restarts and nginx can't create the file. It might be a permissions issue I don't know, I'm really new at this.

If you mkdir /run/nginx and then start the process with nginx it starts up with no issues. Screenshot 2023-04-13 at 19 29 29

I don't know what the deal with the run/ directory is, but to fix this I changed the config for nginx to create the file in /tmp/nginx/nginx.pid and now it starts up happily when I restart the container.

How I Fixed

1. Restart the container.

2. Edit the 3rd line in the `nginx.conf` for me it was `/etc/nginx/nginx.conf`

From:

Screenshot 2023-04-13 at 19 48 51

To: Screenshot 2023-04-13 at 19 50 40

3. Restart the container and confirm nginx is running.
   ![Screenshot 2023-04-13 at 19 52 41](https://user-images.githubusercontent.com/89794691/231906882-3195775e-ec06-41ca-bb38-40f508e0161e.jpg)

Looks like it's working on my end. The fix is genius. Thank you!