ej52 / proxmox-scripts

MIT License
587 stars 308 forks source link

wrong content in "/etc/envirnment" by installer #84

Closed Vitamin-X closed 11 months ago

Vitamin-X commented 2 years ago

the file /etc/envirnment is just a path, but it looks like that

PATH="/bin"

muhdidhamm commented 1 year ago

it works, please merge it.

Vitamin-X commented 1 year ago

still new to github... but setted it to "ready for review"

Vitamin-X commented 1 year ago

seems like nobody cares

Eeems commented 1 year ago

You might want to update the title to be more specific as to what this is doing. It's up to @ej52 to merge it though.

Vitamin-X commented 1 year ago

there are only 8 pull requests so i gues thats not the problem, the last update was also 9 months ago

Eeems commented 1 year ago

there are only 8 pull requests so i gues thats not the problem

There are two open from you with the same title, it's very confusing.

the last update was also 9 months ago

It looks like @ej52 hasn't done anything on github since that date either.

Vitamin-X commented 1 year ago

but does the name matter anyway? i mean they are 8 of them, i would atleast take a look :D

changed them anyway...

ej52 commented 11 months ago

Not relevant anymore due to https://github.com/ej52/proxmox-scripts/pull/146