search

ejbills / DockDoor

Window peeking for macOS
https://dockdoor.net
GNU General Public License v3.0
1.43k stars 34 forks source link

[BUG] Dock with sped up animations causes prematurely hidden window #297

Open gkrawiec opened 2 months ago

gkrawiec commented 2 months ago

Describe the bug

with the update this past week, i can no longer hover over the preview windows. They do show up, but as soon as I try to move the mouse pointer into one of the previews in order to hover or select, the previews instantly close. I already played around with the window buffer so that the window preview is next to or under the dock so that the pointer never but it still closes immediately.

Steps to reproduce

Expected behavior

in the past I could move from the dock icon into the previews in order to select them. I would expect that to still work

Actual behavior

the previews close immediately when the pointer leaves the dock icon. Even if it goes dierctly into the preview.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

Additional context

illavoluntas commented 2 months ago

Duplicate of #291, version 1.2.3 specially patched the issue. Apparently not.

gkrawiec commented 2 months ago

Sorry, but no. This is not about far previews. I saw that post and its video. This is ALL previews. I cant even reach a single preview. I already have 1.2.3 and the problem is still there.

illavoluntas commented 2 months ago

Sorry, but no. This is not about far previews. I saw that post and its video. This is ALL previews. I cant even reach a single preview. I already have 1.2.3 and the problem is still there.

You might want to try to reset DockDoor, but all your settings will be gone. Paste the command defaults delete com.ethanbills.DockDoor into a terminal emulator.

illavoluntas commented 2 months ago

Sorry, but no. This is not about far previews. I saw that post and its video. This is ALL previews. I cant even reach a single preview. I already have 1.2.3 and the problem is still there.

I'm really sorry for the misunderstanding

illavoluntas commented 2 months ago

@gkrawiec Have you also tried restarting DockDoor? As I am unable to reproduce the issue, it might help fixing it.

gkrawiec commented 2 months ago

Just tried

problem is still there.

https://github.com/user-attachments/assets/2de66a22-49a9-40c8-95b6-5caa2186a4f3

illavoluntas commented 2 months ago

That is very strange, thank you for the precisions. Do you happen to have multiple monitors?

gkrawiec commented 2 months ago

Nope, single internal laptop monitor. I did NOT have this problem in the release from before this week. Though I did have the issue where dockdoor would stop working after a while (this has been fixed).

illavoluntas commented 2 months ago

If you have time and saved your work, you could also try restarting your Mac. But as restarting DockDoor didn't work, I'm not sure it might work either...

illavoluntas commented 2 months ago

Could you please screenshot your General and Appearance settings too? Let's see if some settings are triggering this bug or not.

gkrawiec commented 2 months ago

Windows Switcher is DISABLED, all permissions are given.

39345 61178
illavoluntas commented 2 months ago

What does changing Preview Window Open Delay's value do (to a higher one)? Is it the same?

[!NOTE] I'm just trying ways to investigate why this is happening to you. I cannot reproduce the issue, even though I have approximately the same settings as you.

gkrawiec commented 2 months ago

No difference.

What does changing Preview Window Open Delay's value do (to a higher one)? Is it the same?

Note

I'm just trying ways to investigate why this is happening to you. I cannot reproduce the issue, even though I have approximately the same settings as you.

illavoluntas commented 2 months ago

Okay. Did you restart your Mac? Another track you could follow is using Pearcleaner to completely uninstall DockDoor (delete all the files related to it), and reinstall from the GitHub repo.

gkrawiec commented 2 months ago

I've done the uninstall using pearcleaner. I should mention I install using brew cask. problem is still there after reinstall. I have NOT restarted the machine yet. I can't right now, I can try that monday morning.

ejbills commented 2 months ago

Just tried

  • quitting

  • -resetting defaults

  • opening app

problem is still there.

https://github.com/user-attachments/assets/2de66a22-49a9-40c8-95b6-5caa2186a4f3

Why does your dock instantly disappear?

illavoluntas commented 2 months ago

Just tried

  • quitting
  • -resetting defaults
  • opening app

problem is still there.

Screen.Recording.2024-09-07.at.10.19.41.AM.mov

Why does your dock instantly disappear?

Might be some trick using Terminal or simply animations are disabled (accessibility feature).

illavoluntas commented 2 months ago

@ejbills Are you able to reproduce this bug?

gkrawiec commented 2 months ago

I think it's from disabling the delay to open the dock. I use tinkertool to activate that.

68997

Why does your dock instantly disappear?

ejbills commented 2 months ago

@gkrawiec ~~it appears you ran this command to speed up the dock hiding animation: defaults write com.apple.dock autohide-delay -float 0; defaults write com.apple.dock autohide-time-modifier -int 0;killall Dock~~

~~Can you please run this command to reset it to default, and see if the issue persists: defaults delete com.apple.Dock autohide-delay; killall Dock~~

Can you disable that option in tinker tool and see if it fixes the issue?

ejbills commented 2 months ago

i.e;

please try to untick these 2 options:

Disable animation when hiding or showing Dock Disable delay when showing hidden Dock

gkrawiec commented 2 months ago

i used Tinkertool to enable the animation option there (NOT the delay option I highlighted on my previous message)

ENABLING THE ANIMATION FIXES THE PROBLEM.

BUT.....i should mention, i've had the animation disabled since forever and it did not affect dockdoor. This problem started with last week's release.

thank you!

91706
ejbills commented 2 months ago

i used Tinkertool to enable the animation option there (NOT the delay option I highlighted on my previous message)

ENABLING THE ANIMATION FIXES THE PROBLEM.

BUT.....i should mention, i've had the animation disabled since forever and it did not affect dockdoor. This problem started with last week's release.

thank you!

91706

I figured that was the issue, it's just something we didn't test for. I will see if I can make it compatible with this tinker tool option.

illavoluntas commented 2 months ago

If I remember correctly 1.2.0 changed the way DockDoor detected the Dock. This might be connected.

gkrawiec commented 2 months ago

If I remember correctly 1.2.0 changed the way DockDoor detected the Dock. This might be connected.

Great catch. It didnt even cross my mind I have a non standard setting for the dock animation. It is something I just disable when I install macos.

thank you!

illavoluntas commented 2 months ago

If I remember correctly 1.2.0 changed the way DockDoor detected the Dock. This might be connected.

Great catch. It didnt even cross my mind I have a non standard setting for the dock animation. It is something I just disable when I install macos.

thank you!

You're welcome @gkrawiec! I was pleased to investigate the source of the problem :slightly_smiling_face:

illavoluntas commented 2 months ago

@ejbills TinkerTool isn't an open-source program. I hope you can figure out how it disables the Dock animation.

gkrawiec commented 2 months ago

maybe this? https://www.xda-developers.com/how-accelerate-dock-macos-terminal/

@ejbills TinkerTool isn't an open-source program. I hope you can figure out how it disables the Dock animation.

illavoluntas commented 2 months ago

Oh, yes, I even watched a video today on how to speed up this animation :man_facepalming:.

ejbills commented 2 months ago

@ejbills TinkerTool isn't an open-source program. I hope you can figure out how it disables the Dock animation.

Anything that changes how the dock operates is simply editing the dock prefs file. This option in tinker tool is literally just running this command:

defaults write com.apple.dock autohide-delay -float 0; defaults write com.apple.dock autohide-time-modifier -int 0;killall Dock

illavoluntas commented 2 months ago

No problem then, let's hope there is a possible patch for DockDoor! :rocket:

MattSuda commented 2 months ago

I'm having the same issue with hovering over the window previews since the recent update.

I also have dock animations sped up using TinkerTool.

I'm really hoping that the recent changes can be updated to support these faster animations. I never had this issue with HyperDock. The Dock is too slow without these options enabled, and I find the faster animations to be much better.

MattSuda commented 1 month ago

Not sure if it's related to this issue, but DockDoor just randomly stops running.

I restart DockDoor and I see it's running for a while and then suddenly it's not open and running anymore. It just closes / crashes in the background. I haven't seen any other reports, so might be related to this issue here.

illavoluntas commented 1 month ago

Not sure if it's related to this issue, but DockDoor just randomly stops running.

I restart DockDoor and I see it's running for a while and then suddenly it's not open and running anymore. It just closes / crashes in the background. I haven't seen any other reports, so might be related to this issue here.

243 is similar, looks like that the bug reappeared…

MattSuda commented 1 month ago

With the previous bug, the preview windows would not show up, but the app would still be open. For this bug, when I check the menubar, the icon is also gone like the app has been closed out. Seems to happen after a few days of the app running.

Since I haven't seen any other reports, I thought it might be due to this other bug I am having because I have the sped up dock animations.

I'll keep an eye on the bug and next time I will check to see if the app process is still running or not.