search

ejci / Chrome-Audio-EQ

Audio EQ for Chrome
GNU General Public License v2.0
107 stars 40 forks source link

Audible noise when closing tabs #18

Closed jessejoe closed 7 years ago

jessejoe commented 9 years ago

I'm using the EQ for listening to Google Play Music, and it works great. However frequently when closing a tab, there will be an audible scratch/break in sound. I've uninstalled/reinstalled the extension multiple times to confirm it's definitely the extension and not Google Play Music. It doesn't occur when the extension is not installed. I'm using a basically new MBP, so I don't think it's a resources issue. Let me know if there's anything I can do to help debug.

ejci commented 9 years ago

Can you please also share Chrome version?

jessejoe commented 9 years ago

39.0.2171.95 (64-bit)

jessejoe commented 9 years ago

Here is an example URL that causes the glitch every time it is closed while Google Play is playing with Chrome-Audio-EQ extension enabled - http://www.mrgamez.com/starburst/

ejci commented 9 years ago

Awesome. Thanks! I will look into it

jessejoe commented 9 years ago

For reference, here's another link that causes the issue when closed - http://www.damian.oquanta.info/posts/hide-the-input-cells-from-your-ipython-slides.html

jessejoe commented 9 years ago

Any idea when this fix make it to an official release? Is there a pre-release we can test?

ejci commented 9 years ago

I will release new version in 2-3 days. But you can try it already. Just download the source. Then enable developer mode in chrome://extensions and load unpacked extension (extension folder in repo).

I tested it on the page and I found the problem so it should work. On the pages you've sent there were too many iframes and the extension was creating too many audio contexts (max is 6 per page). And because of that it was making the weird "crack" sound.

jessejoe commented 9 years ago

Tried it and it seems to work great, thanks for the timely fix!

ejci commented 9 years ago

I will close the issue once the fix is released with new version

jessejoe commented 9 years ago

Just FYI this fix still doesn't appear to have made it to the web store.

Also, just FYI this issue does still occur occasionally. It's not as bad as before, but for instance this URL will still cause it - https://support.pagerduty.com/hc/en-us/articles/203565440-Using-Override-System-Volume-on-Android-L-Lollipop-5-0

ejci commented 9 years ago

I will look into it. And hopefully finish the new version this weekend

l3db3tt3r commented 9 years ago

I have this Issue as well, scratch sound, differs in tone and briefness of length: Audio EQ 0.3.1.2 Chrome 40.0.2214.111 (64-bit)

I am unable to reproduce it reliably. It seems to happen more when I have a tab open for a bit of time.

vkammerer commented 9 years ago

Same here, each time i close a tab in the window running my player, I hear a "crash sound"

l3db3tt3r commented 9 years ago

Update: I haven't had this issue since upgrading Chrome: 44.0.2377.0 canary (64-bit)