search

ejci / Chrome-Audio-EQ

Audio EQ for Chrome
GNU General Public License v2.0
107 stars 40 forks source link

Chrome-Audio-EQ Disables Sound on tunein.com #28

Closed nealvb closed 9 years ago

nealvb commented 9 years ago

Hi suddenly around mid April 2015 I stopped getting Audio (tunin.com) on one of my PC's via chrome after tinkering around found it works (sound comes through) in incognito (where the plugin is diabled).

ejci commented 9 years ago

I will check that. Thanks for letting me know

nealvb commented 9 years ago

Cool Thank you for awesome plugin On 30 Apr 2015 15:18, "Miroslav Magda" notifications@github.com wrote:

I will check that. Thanks for letting me know

— Reply to this email directly or view it on GitHub https://github.com/ejci/Chrome-Audio-EQ/issues/28#issuecomment-97776755.

hierovision commented 9 years ago

I'd like to add that I also lose sound with this plugin enabled while in https://clyp.it/ and the steam web store while watching videos.

skylize commented 9 years ago

Line numbers below are in reference to page.js at commit f56a7ef194.

Some leads on fixing tunein.com, but haven't pinpointed it yet. It uses a stream url that looks like http://icy1.abacast.com/kplu-jazz24mp3-32 with no trailing slash and no file extension. When the extension is running, a forward slash and semicolon are somehow getting appended to the end causing a 404, so the above url gets transformed to http://icy1.abacast.com/kplu-jazz24mp3-32/;

On page load, the audio element has no source, so I tried conditionally adding crossorigin attribute (line 91) only if it doesn't exist and commenting out the line that resets the src (line 96). In that case src is only set by the app, instead of the extension, so the first time that if (target.src) matches at line 93, src is correct without the trailing characters. However it still gets mangled before attach() (function lines 74-122) is called again and before the audio can start playing. Line 96 is the only time we explicitly set an element's src so its apparently a side effect of something else.

skylize commented 9 years ago

Clyp.it is another issue altogether. With the extension disabled, if I just add crossorigin to the audio element from DevTools, a clip will continue playing till if finishes, but cannot be played a second time. Additionally, if the extension is enabled, but set to disabled for that site, it still breaks playback.

ejci commented 9 years ago

I will release 0.3.2.1 version with fix

skylize commented 9 years ago

I think it's worth clarifying what was and was not fixed. The EQ still cannot actually be used on either tunein.com or on clyp.it. However fix ed49d1f makes the context menu option to "Disable for this domain" more reliable, so it's possible to use these sites without having to completely disable the extension.

ejci commented 9 years ago

Yes you are right. Sorry for not being clear.

Morteza-Rastgoo commented 8 years ago

this problem still not fixed?

nealvb commented 8 years ago

Hi just checked on tunein.com. the following happens:

Open Chrome (Audio EQ currently disabled) Go to tunein.com and stream something -- all good Enable Audio EQ -- all good Try change the EQ -- audio is not effected Close and reopen Chrome (Audio EQ currently enabled) Go to tune.com and stream something -- get the following error message from tunein.com "We Didn't Find Any Playable Streams" Disable Audio EQ -- still same error message Close and reopen chrome (Audio EQ currently disabled) *Go to tune.com and stream something -- all good

Just check cliffcentral.com (another site I stream from) --ALL GOOD with Audio EQ Though I see I have to disable or enable Audio EQ before I open a tab(site) that I'm going to stream from ...didn't realize that So for me no, not yet fixed. ( In fact worse than before though I'm now running via chrome signed in where as before I was not) Pity though :( ...as I really liked this extension.