search

ejci / Chrome-Audio-EQ

Audio EQ for Chrome
GNU General Public License v2.0
106 stars 40 forks source link

Added feature for custom presets #5

Closed christj6 closed 9 years ago

christj6 commented 10 years ago

Hello! I added a capability to let the user add and save a custom preset to the equalizer. The user clicks the "Add Custom" button and a prompt appears, asking the user what they wish to name this new preset. Once the user clicks OK, the state of the EQ sliders (eq[1].gain through to eq[10].gain) and the name is pushed to the PRESETS array and the name of the preset is added to the bottom of the drop-down menu. I haven't yet implemented a way for the preset to be permanently saved in the user's browser -- I believe it remains in memory for that session. I'm currently looking into improving the feature.

I initially tried to implement this feature reading a text file, but shelved the idea, and reverted "const.js" back to its prior state.

ejci commented 10 years ago

Hi, I was thinking about this feature as it was requested by few users. Im planning to add custom presets support but in a different way. Recently I moved to the different country and started new job so I don't have time for it. But I will do it in few weeks.

It will be implemented differently because I will add few more features that will make life easier and also I will add feature that will indicate if EQ is working or not (if there is HTML5 audio/video).

ejci commented 10 years ago

And thanks for contribution. I will try to pull your code a reuse it in the next version. I really appreciate your help!

christj6 commented 10 years ago

Thank you! I look forward to seeing where this extension goes next.