search

ejci / Chrome-Audio-EQ

Audio EQ for Chrome
GNU General Public License v2.0
107 stars 40 forks source link

Not working in Chrome 36.0.1985.125 #9

Closed ejci closed 9 years ago

ejci commented 10 years ago

Chrome Audio EQ ver.0.3.1.0 and Audio EQ ver.0.3.1.1 were worked well until Chrome 35. Thankful. But not working in Chrome 36.0.1985.125. Please fix.

ghost commented 9 years ago

Hi! I like the extension and would like to help. Currently I found the bug:

Uncaught Error: Error connecting to extension hllgldhpkcmmfkcdmendfhgbgnfkbiah

Which refers to issue described here: https://code.google.com/p/chromium/issues/detail?id=168263

The problem is in chrome.runtime.sendMessage call here: https://github.com/ejci/Chrome-Audio-EQ/blob/master/extension/popup/popup.js#L34

ghost commented 9 years ago

webkitAudioContext.createGainNode() was deprecated and renamed to webkitAudioContext.createGain

https://github.com/ejci/Chrome-Audio-EQ/blob/master/extension/page/page.js#L37

Details here: https://code.google.com/p/chromium/issues/detail?id=395130

ejci commented 9 years ago

I published your fix (version 0.3.1.2)... it should be public soon. Thanks for help!