search

ejdecena / openacademy

0 stars 0 forks source link

[ADD] openacademy: new module to manage an academy. #1

Closed ejdecena closed 2 years ago

ejdecena commented 2 years ago

These are the exercises 1 to 10 of the Building a Module.

ejdecena commented 2 years ago

Done all :)

luisg123v commented 2 years ago

Missing this part:

Once applied, you may update PR title and description to match commit's ones.

ejdecena commented 2 years ago

In the description of the PR commit, should I make reference to each of the previous commits?

luisg123v commented 2 years ago

In the description of the PR commit, should I make reference to each of the previous commits?

Not necessary. Separated commits were important to evaluate progress during the process, but once a PR is ready to be merged, only one commit is (usually) kept with the final result.

ejdecena commented 2 years ago

All done :)

luisg123v commented 2 years ago

I noticed PR's description and commit's description differ, they should be the same. Either edit PR description to match commit or reword commit to match PR