search

ejeinc / MetalScope

Metal-backed 360° panorama view for iOS
MIT License
324 stars 72 forks source link

swift 4 is not supported #37

Open vadimkononov opened 6 years ago

vadimkononov commented 6 years ago

hi, steps to reproduce:

  1. create a new project in xcode9
  2. add podfile with pod 'MetalScope' in it
  3. build

AR: build failed (screenshots attached)

screen shot 2017-10-24 at 10 01 58 screen shot 2017-10-24 at 10 02 17
ElizaSapir commented 6 years ago

Hey @junpluse we have customers with swift4 already, looks like you did some xcode9 fixes do we miss somthing?

Thanks!

toemat commented 6 years ago

I'm not sure this is a Swift 4 issue. I got the same thing with Swift 3.2. It looks like maybe the Metal API changed some things to optionals?

Either way, going through and doing the Xcode fix for each error got it working for me.