search

ejeinc / MetalScope

Metal-backed 360° panorama view for iOS
MIT License
324 stars 72 forks source link

Deadlock with large files #5

Closed giln closed 7 years ago

giln commented 7 years ago

Hello,

We experience some deadlock when using large images (around 50mb).

It seems the issue is with the DeviceOrientationProvider.

Commenting the following lines in the StereoView fixes the deadlock.

if let provider = orientationNode.deviceOrientationProvider, provider.shouldWaitDeviceOrientation(atTime: time) {
            provider.waitDeviceOrientation(atTime: targetTime)
        }
giln commented 7 years ago

It seems the issue is not caused by the large files but because our App is configured only for Landscape Left Orientation. Since it is locked in only 1 orientation, it waits indefinitely for device Orientation.

junpluse commented 7 years ago

Hi @giln,

Thanks for your report, and sorry for the late reply. 🙇 Is there an example project to demonstrate the issue?

junpluse commented 7 years ago

I fixed a potential infinite waiting issue in #7, and released it as a part of 0.6.0. Please try the latest version in your project.