ejektaflex / Bountiful

A Minecraft mod adding bounties for specific items.
https://minecraft.curseforge.com/projects/bountiful
GNU General Public License v3.0
82 stars 31 forks source link

[Bug]: Crash when dropping Bounty with Loot Beams installed #153

Closed AnnaErisian closed 1 year ago

AnnaErisian commented 2 years ago

What happened?

I dropped a bounty from the board and later from my inventory. The game crashed. Reproduced with only those two mods, but originally discovered in Magical Mischief Tour

Reloading the world does crashes again after a second or so.

Blacklisting Bountiful items in Loot Beams solves the issue.

How can we reproduce it?

Install this mod, Loot Beams lootbeams-1.16.5-release-sept0621, and Kotlin for Forge 1.15.1 with Forge 36.2.2

Mod Version

Bountiful-1.16.4-3.3.1

Forge Version

36.2.2

Relevant log output

---- Minecraft Crash Report ---- // Don't be sad. I'll do better next time, I promise!

Time: 9/30/21 9:57 PM Description: Rendering entity in world

java.lang.NullPointerException: Rendering entity in world at ejektaflex.bountiful.item.ItemBounty.func_77624_a(ItemBounty.kt:105) ~[bountiful:1.16.4-3.3.1] {re:classloading} at net.minecraft.item.ItemStack.func_82840_a(ItemStack.java:578) ~[?:?] {re:classloading,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack} at com.lootbeams.LootBeamRenderer.renderNameTag(LootBeamRenderer.java:127) ~[lootbeams:1.16.5-release] {re:classloading} at com.lootbeams.LootBeamRenderer.renderLootBeam(LootBeamRenderer.java:86) ~[lootbeams:1.16.5-release] {re:classloading} at com.lootbeams.ClientSetup.onRenderNameplate(ClientSetup.java:59) ~[lootbeams:1.16.5-release] {re:classloading} at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:247) ~[eventbus-4.0.0.jar:?] {} at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:239) ~[eventbus-4.0.0.jar:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:302) ~[eventbus-4.0.0.jar:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:283) ~[eventbus-4.0.0.jar:?] {} at net.minecraft.client.renderer.entity.EntityRenderer.func_225623a(EntityRenderer.java:64) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.entity.ItemRenderer.func_225623a(ItemRenderer.java:91) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.entity.ItemRenderer.func_225623a(ItemRenderer.java:20) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.entity.EntityRendererManager.func_229084a(EntityRendererManager.java:251) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.WorldRenderer.func_228418a(WorldRenderer.java:1202) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.WorldRenderer.func_228426a(WorldRenderer.java:1010) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.GameRenderer.func_228378a(GameRenderer.java:608) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.GameRenderer.func_195458_a(GameRenderer.java:425) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:976) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:607) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.main.Main.main(Main.java:184) ~[minecraft-1.16.5-client.jar:?] {re:classloading,pl:runtimedistcleaner:A} at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_292] {} at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_292] {} at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_292] {} at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_292] {} at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) ~[forge-1.16.5-36.2.2-launcher.jar:36.2] {} at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?] {} at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_292] {} at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_292] {} at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_292] {} at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_292] {} at io.github.zekerzhayard.forgewrapper.installer.Main.main(Main.java:52) [ForgeWrapper-1.5.1.jar:1.5.1] {} at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_292] {} at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_292] {} at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_292] {} at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_292] {} at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:210) [NewLaunch.jar:?] {} at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:245) [NewLaunch.jar:?] {} at org.multimc.EntryPoint.listen(EntryPoint.java:143) [NewLaunch.jar:?] {} at org.multimc.EntryPoint.main(EntryPoint.java:34) [NewLaunch.jar:?] {}

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head -- Thread: Render thread Stacktrace: at ejektaflex.bountiful.item.ItemBounty.func_77624_a(ItemBounty.kt:105) ~[bountiful:1.16.4-3.3.1] {re:classloading} at net.minecraft.item.ItemStack.func_82840_a(ItemStack.java:578) ~[?:?] {re:classloading,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack} at com.lootbeams.LootBeamRenderer.renderNameTag(LootBeamRenderer.java:127) ~[lootbeams:1.16.5-release] {re:classloading} at com.lootbeams.LootBeamRenderer.renderLootBeam(LootBeamRenderer.java:86) ~[lootbeams:1.16.5-release] {re:classloading} at com.lootbeams.ClientSetup.onRenderNameplate(ClientSetup.java:59) ~[lootbeams:1.16.5-release] {re:classloading} at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:247) ~[eventbus-4.0.0.jar:?] {} at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:239) ~[eventbus-4.0.0.jar:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:302) ~[eventbus-4.0.0.jar:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:283) ~[eventbus-4.0.0.jar:?] {} at net.minecraft.client.renderer.entity.EntityRenderer.func_225623a(EntityRenderer.java:64) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.entity.ItemRenderer.func_225623a(ItemRenderer.java:91) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.entity.ItemRenderer.func_225623a(ItemRenderer.java:20) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} -- Entity being rendered -- Details: Entity Type: minecraft:item (net.minecraft.entity.item.ItemEntity) Entity ID: 333 Entity Name: Bounty Entity's Exact location: 156.54, 76.32, 54.91 Entity's Block location: World: (156,76,54), Chunk: (at 12,4,6 in 9,3; contains blocks 144,0,48 to 159,255,63), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,0,0 to 511,255,511) Entity's Momentum: 0.17, -0.12, -0.05 Entity's Passengers: [] Entity's Vehicle: ERROR NullPointerException: null

-- Renderer details -- Details: Assigned renderer: net.minecraft.client.renderer.entity.ItemRenderer@69346100 Location: 0.00,-0.30,0.00 - World: (0,-1,0), Chunk: (at 0,-1,0 in 0,0; contains blocks 0,0,0 to 15,255,15), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,0,0 to 511,255,511) Rotation: 76.689316 Delta: 0.87959075 Stacktrace: at net.minecraft.client.renderer.entity.EntityRendererManager.func_229084a(EntityRendererManager.java:251) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.WorldRenderer.func_228418a(WorldRenderer.java:1202) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.WorldRenderer.func_228426a(WorldRenderer.java:1010) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.GameRenderer.func_228378a(GameRenderer.java:608) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}

-- Affected level -- Details: All players: 1 total; [ClientPlayerEntity['The_Erisian'/185, l='ClientLevel', x=156.54, y=75.00, z=54.91]] Chunk stats: Client Chunk Cache: 625, 420 Level dimension: minecraft:overworld Level spawn location: World: (160,72,48), Chunk: (at 0,4,0 in 10,3; contains blocks 160,0,48 to 175,255,63), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,0,0 to 511,255,511) Level time: 3476 game time, 3476 day time Server brand: forge Server type: Integrated singleplayer server Stacktrace: at net.minecraft.client.world.ClientWorld.func_72914_a(ClientWorld.java:447) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.func_71396_d(Minecraft.java:2029) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:623) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.main.Main.main(Main.java:184) ~[minecraft-1.16.5-client.jar:?] {re:classloading,pl:runtimedistcleaner:A} at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_292] {} at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_292] {} at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_292] {} at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_292] {} at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) ~[forge-1.16.5-36.2.2-launcher.jar:36.2] {} at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?] {} at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_292] {} at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_292] {} at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_292] {} at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_292] {} at io.github.zekerzhayard.forgewrapper.installer.Main.main(Main.java:52) [ForgeWrapper-1.5.1.jar:1.5.1] {} at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_292] {} at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_292] {} at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_292] {} at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_292] {} at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:210) [NewLaunch.jar:?] {} at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:245) [NewLaunch.jar:?] {} at org.multimc.EntryPoint.listen(EntryPoint.java:143) [NewLaunch.jar:?] {} at org.multimc.EntryPoint.main(EntryPoint.java:34) [NewLaunch.jar:?] {}

-- System Details -- Details: Minecraft Version: 1.16.5 Minecraft Version ID: 1.16.5 Operating System: Linux (amd64) version 5.14.7-arch1-1 Java Version: 1.8.0_292, Oracle Corporation Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Oracle Corporation Memory: 7209958008 bytes (6875 MB) / 8589934592 bytes (8192 MB) up to 8589934592 bytes (8192 MB) CPUs: 8 JVM Flags: 8 total; -XX:+UseG1GC -XX:+UnlockExperimentalVMOptions -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=51 -XX:G1HeapRegionSize=32M -Xms8192m -Xmx8192m ModLauncher: 8.0.9+86+master.3cf110c ModLauncher launch target: fmlclient ModLauncher naming: srg ModLauncher services: /mixin-0.8.2.jar mixin PLUGINSERVICE /eventbus-4.0.0.jar eventbus PLUGINSERVICE /forge-1.16.5-36.2.2-launcher.jar object_holder_definalize PLUGINSERVICE /forge-1.16.5-36.2.2-launcher.jar runtime_enum_extender PLUGINSERVICE /accesstransformers-3.0.1.jar accesstransformer PLUGINSERVICE /forge-1.16.5-36.2.2-launcher.jar capability_inject_definalize PLUGINSERVICE /forge-1.16.5-36.2.2-launcher.jar runtimedistcleaner PLUGINSERVICE /mixin-0.8.2.jar mixin TRANSFORMATIONSERVICE /forge-1.16.5-36.2.2-launcher.jar fml TRANSFORMATIONSERVICE FML: 36.2 Forge: net.minecraftforge:36.2.2 FML Language Providers: javafml@36.2 minecraft@1 kotlinforforge@1.15.1 Mod List: forge-1.16.5-36.2.2-client.jar |Minecraft |minecraft |1.16.5 |DONE |Manifest: NOSIGNATURE forge-1.16.5-36.2.2-universal.jar |Forge |forge |36.2.2 |DONE |Manifest: 22:af:21:d8:19:82:7f:93:94:fe:2b:ac:b7:e4:41:57:68:39:87:b1:a7:5c:c6:44:f9:25:74:21:14:f5:0d:90 Bountiful-1.16.4-3.3.1.jar |Bountiful |bountiful |1.16.4-3.3.1 |DONE |Manifest: NOSIGNATURE lootbeams-1.16.5-release-sept0621.jar |LootBeams |lootbeams |1.16.5 |DONE |Manifest: NOSIGNATURE Crash Report UUID: db1b0b72-b791-4017-a382-90226d03d6c5 Launched Version: MultiMC5 Backend library: LWJGL version 3.2.2 build 10 Backend API: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 GL version 4.6.0 NVIDIA 470.74, NVIDIA Corporation GL Caps: Using framebuffer using OpenGL 3.0 Using VBOs: Yes Is Modded: Definitely; Client brand changed to 'forge' Type: Client (map_client.txt) Graphics mode: fancy Resource Packs: vanilla (incompatible), mod_resources, openloader/resources/TetraCompatResourcePack.zip, quark:emote_resources (incompatible), file/MischiefMoney.zip, openloader/resources/TipsResourcePack.zip, openloader/resources/MMT_Guide_Resources.zip Current Language: English (US) CPU: 8x Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz

Ov3rPowerD commented 2 years ago

Does anyone know a way to stop the crash or delete the dropped item? I made a modpack and I dropped a bounty with the loot beams mod installed and it crashed my game and now I can't load my world.

ejektaflex commented 2 years ago

I'll have to try match this data to see what it is calling when in have some time!

GlowPon3 commented 2 years ago

Does anyone know a way to stop the crash or delete the dropped item? I made a modpack and I dropped a bounty with the loot beams mod installed and it crashed my game and now I can't load my world.

if you are fast enough, teleport to the location of the dropped item and do /kill @e[type=item,distance=0..100] or just /kill @e[type=item] with it loaded. Looking for a better solution but that's the best I have. You can use NBT explorer on your playerdata to move your pos away from the area so you can load in.

n0itLT commented 2 years ago

Having this issue on server side.

n0itLT commented 2 years ago

Clients are crashing when they throw the bounty out. Are there ANY FIXES for this yet?

ejektaflex commented 2 years ago

I'm a bit busy right now with some personal life events that are going on, so it's going to have to wait for a bit. Sorry about that!

AnnaErisian commented 2 years ago

Clients are crashing when they throw the bounty out. Are there ANY FIXES for this yet?

Blacklisting Bountiful items in Loot Beams solves the issue.

ejektaflex commented 1 year ago

This should be fixed in 1.19.4+, and the above user gave a solution for the version in question. As such, I'll be closing this :)