search

ejektaflex / Bountiful

A Minecraft mod adding bounties for specific items.
https://minecraft.curseforge.com/projects/bountiful
GNU General Public License v3.0
82 stars 31 forks source link

[bug report]: GoodOlCurrency compat #169

Closed AndMattBurt closed 1 year ago

AndMattBurt commented 2 years ago

What happened?

I recieved the wrong currency as a reward, it would only give me 1 dollar bills despite using /bo hand

interestingly though, only the same value rewards would stack even though they look the same

currency_rews (broken).zip

How can we reproduce it?

use /bo hand on any value of note from the mod, paste that as a reward complete a task for the reward, recieve 1 dollar bill

(note: all say 1 dollar in the reward even though its identifying the tag of a higher value

Mod Version

1.16.4 - 3.3.1

Forge Version

1.16.5 - 36.2.26

Relevant log output

No response

ejektaflex commented 2 years ago

It's because they are using a byte value for the currency size - this is one of the few times where the NBT won't work here ("0b"), I don't think. I switched to using the uglier, but more correct version for Fabric. I'll leave this open, but it's not my priority to fix.

Aiyron commented 1 year ago

I said this to help but my mod is functional with since the currency is named "coin_stone" for example.

"Aiycoin" for the name take a look to see

ejektaflex commented 1 year ago

Hi - I won't be releasing new updates for the 1.16.5 version, so this will not be resolved. However, I don't think that this would have been easily solved, because it sounds like coins have assigned NBT with that mod, and the NBT counts them as separate coins.