ejektaflex / Bountiful

A Minecraft mod adding bounties for specific items.
https://minecraft.curseforge.com/projects/bountiful
GNU General Public License v3.0
91 stars 32 forks source link

[Feature]: lower reward value deviation #170

Closed AndMattBurt closed 1 year ago

AndMattBurt commented 2 years ago

Feature Description

a closer value comparison when generating rewards (to assist with a server economy) we are seeing trades worth over 4million X input image lightmans_rews.zip custom_objs.zip Screenshot 2022-02-16 113348

Feature Benefits

less outrageous rewards for items!

AndMattBurt commented 2 years ago

If there is something I am doing wrong (potentially with weighting) that would be helpful to add to the wiki

ejektaflex commented 2 years ago

In this version of Bountiful, value is different depending on rarity tier, making it so that less of the objective is needed to get the reward at higher rarity tiers.

This has been overhauled in Fabric, where we still try to do weight matching similarly, but do not factor in rarity tiers for purposes of value.

To be honest, I never designed Bountiful to be used at such high values (though I'm happy to see people using it in creative ways! :^) ), so I didn't foresee the proportions being so far off. I'm guessing that you are using these as "quests" for late game automation.

The solution would be to switch to how the Fabric version does their bounty calculations, though I unfortunately don't see that happening very soon. I don't have a ton of free time, and most of it goes into making the Fabric version better.

ejektaflex commented 1 year ago

1.19.4+ versions have a unified codebase between Fabric and Forge, which means this this is no longer a problem on newer versions of Bountiful (6.0.0+).