ejektaflex / Bountiful

A Minecraft mod adding bounties for specific items.
https://minecraft.curseforge.com/projects/bountiful
GNU General Public License v3.0
91 stars 32 forks source link

Free Decrees w/Inventory Sorting Mod #199

Closed Lemuhi closed 1 year ago

Lemuhi commented 2 years ago

Hey there, I'm sure this is not intended, but I use the "Better minecraft" modpack for 1.18.1 fabric, and I have a sort inventory button... This allows you to gain just about any decree you want from the bounty board as it will put the decree inside the same inventory as where the bounties are located, allowing you to transfer it to your own inventory. If you choose to close the window and there is no decree in the decree slots, it will generate a new decree which means you can get all of them by just sorting inventory enough times.

Not sure what mod the sorting button comes from exactly, but this seems like an unintended conflict with that mod.

ejektaflex commented 2 years ago

Huh, that's a new one, thanks!

ejektaflex commented 2 years ago

If you could attach a mod list via a log or a screenshot or some such, that'd help a lot. :^)

Lemuhi commented 2 years ago

2022-03-15-2.log.gz it is quite a few mods in that mod pack, but the mod itself that causes it should be this one: https://www.curseforge.com/minecraft/mc-mods/inventory-sorting

ejektaflex commented 1 year ago

I've looked into this, and can replicate the issue. The problem is that Inventory Sorting does not seem to respect the canInsert and canTakeItems methods of those slots and moves items around willy-nilly without thinking about whether it should be able to move items around. This isn't a problem with Bountiful, but rather a consideration that Inventory Sorting needs to make.

I posted an issue to their issue tracker here.