ejektaflex / Bountiful

A Minecraft mod adding bounties for specific items.
https://minecraft.curseforge.com/projects/bountiful
GNU General Public License v3.0
82 stars 31 forks source link

[Bug, 1.20.1]: Villager Hats compat warning #214

Open ejektaflex opened 1 year ago

ejektaflex commented 1 year ago

What happened?

I got a crash, saying that #villager-hats:hats does not exist.

This is probably due to an incorrect compat entry - and could easily be avoided if we validated entries more thoroughly when joining into a world.

How can we reproduce it?

No response

Mod Version

6.0.0-beta.3

Mod Loader

Fabric

Mod Loader Version

0.76.0+1.19.4

Relevant log output

No response

ejektaflex commented 1 year ago

Fixing this would also fix #141 ! It would also notify us when things go wrong, such as #128.

ejektaflex commented 1 year ago

This is fixed as of 4b4294c and 6.0.2

NovelPhacelia commented 11 months ago

getting this problem on 1.20.1 mod 6.0.2 fabric [16:11:35] [Server thread/WARN]: Bountiful reward pool entry is not valid!: all_rew_villager_hats_random_hat [16:11:35] [Server thread/WARN]: Bounty Pool Entry Invalid: (all_rew_villager_hats_random_hat - #villager-hats:hats) details: { "type": "minecraft:item_tag", "rarity": "RARE", "content": "#villager-hats:hats", "name": null, "icon": null, "amount": { "min": 1, "max": 1 }, "unitWorth": 2000.0, "weightMult": 0.009090909090909092, "timeMult": 1.0, "repRequired": 0.0, "forbids": [ ], "conditions": null, "mystery": false, "nbt": null }

ejektaflex commented 11 months ago

This doesn't seem to be a problem to me - rather, the new system is working exactly as intended and avoiding a crash. However, I'll reopen this and investigate why it might not be valid 😄