ejektaflex / Bountiful

A Minecraft mod adding bounties for specific items.
https://minecraft.curseforge.com/projects/bountiful
GNU General Public License v3.0
82 stars 31 forks source link

[Bug, 1.20.1]: Villager Hats compat causing clients to disconnect on servers #244

Open NovelPhacelia opened 11 months ago

NovelPhacelia commented 11 months ago

What happened?

Clients disconnect from server when bounties update with villager hats, Villager Hats version 1.6.1

How can we reproduce it?

  1. Join a server with Villager Hat and Bountiful (This don't work on client, but still outputs logs)
  2. Go to a village

Mod Version

6.0.3

Mod Loader

Fabric

Mod Loader Version

0.86.0

Relevant log output

latest.log [16:24:25] [Server thread/WARN]: Bountiful reward pool entry is not valid!: all_rew_villager_hats_random_hat [16:24:25] [Server thread/WARN]: Bounty Pool Entry Invalid: (all_rew_villager_hats_random_hat - #villager-hats:hats) details: { "type": "minecraft:item_tag", "rarity": "RARE", "content": "#villager-hats:hats", "name": null, "icon": null, "amount": { "min": 1, "max": 1 }, "unitWorth": 2000.0, "weightMult": 0.009090909090909092, "timeMult": 1.0, "repRequired": 0.0, "forbids": [ ], "conditions": null, "mystery": false, "nbt": null }

ejektaflex commented 11 months ago

Interesting - do you have a client version of this log? This simply contains warnings and no crash; it could be a recursive loop timing out, but I don't see any sort of recursive stack limit being reached.

NovelPhacelia commented 11 months ago

latest.log Tried it with the full list of mods and got the same result, it only disconnects me on servers but the server itself never crashes

ejektaflex commented 11 months ago

For now, you can disable the Villager Hats compat datapack by running this on the server: /datapack disable "bountiful:compat-villager-hats" I hope that helps!

NovelPhacelia commented 11 months ago

Thanks! I'll try this

viktordimov commented 4 months ago

It also happens on single player worlds, causing "invalid player data" error