ejektaflex / Bountiful

A Minecraft mod adding bounties for specific items.
https://minecraft.curseforge.com/projects/bountiful
GNU General Public License v3.0
82 stars 31 forks source link

[Bug]: Crash with BountyItem #286

Open RawrUniversal opened 1 month ago

RawrUniversal commented 1 month ago

What happened?

Crashed when clicking the bounty item. The Griefdefender dev said that it called "stack.getDisplayName()" when it crashes.

How can we reproduce it?

No response

Mod Version

6.0.3+1.20.1

Mod Loader

Fabric

Mod Loader Version

0.92.2+1.20.1

Relevant log output

crash-2024-06-07_07.09.00-server.txt

ejektaflex commented 1 month ago

Hi @RawrUniversal ! It seems like this is because we're doing a client server data pull on the server side. Base Minecraft has no reason to do this and quite frankly, most mods don't have any reason to do this either (Otherwise I would have received a bug report earlier, this code was committed 3.5 years ago according to this).

I will be fixing this, but only for an upcoming version and not for 1.20.1. Thanks for the bug report!