ejektaflex / Kambrik

A Lightweight Kotlin-Fabric Library
https://kambrik.ejekta.io/
10 stars 4 forks source link

3.0.1-1.18 Crash on startup #11

Closed ClaudiusMinimus closed 2 years ago

ClaudiusMinimus commented 2 years ago

I am in the process of updating my pack, 99 Mods on the Wall: Fabric Edition. I updated Kambrik to 3.0.1-1.18 and it crashes the client. However, when I revert to 3.0.0-1.18 it runs fine.

https://crashy.net/urs4tnqTSTcPokUAyK1D or https://crashy.net/urs4tnqTSTcPokUAyK1D?raw

grugsy commented 2 years ago

Same. The game fails to launch. crash-2022-01-08_22.44.36-server.txt

ejektaflex commented 2 years ago

Fixed, duplicate of #10

Update to the newest version of Bountiful, that works with Kambrik 3.1.0!

isXander commented 2 years ago

I also have this issue with my mod. What actually is the fix? @ejektaflex

ejektaflex commented 2 years ago

@isXander is this a mod you've already released? If so, rebuild and rerelease.

I didn't expect this bug - it has to do with the fact that the compiled mod class files (Bountiful in this instance) were not compiled when the auto registrar had default method implementations - thus, Bountiful thought that it was not implementing the registration methods even though it wasn't required (but not oddly didn't know that it wasn't required).

Seems to be a quirk with how Kotlin handles interface default implementations, it must compile them directly into inheriting subclasses.