search

ejeschke / ginga

The Ginga astronomical FITS file viewer
BSD 3-Clause "New" or "Revised" License
121 stars 77 forks source link

MNT: Replace deprecated PIL calls #1001

Closed pllim closed 2 years ago

pllim commented 2 years ago

This pull request is to get rid of these warnings in CI that appeared with Pillow 9.1.0 release:

DeprecationWarning: XXX is deprecated and will be removed in Pillow 10 (2023-07-01). Use Resampling.XXX instead.

DeprecationWarning: XXX is deprecated and will be removed in Pillow 10 (2023-07-01). Use Intent.XXX instead.

ejeschke commented 2 years ago

I'm also ok with the PR as is if you think it is more clear.

pllim commented 2 years ago

@ejeschke , I would prefer to have it as-is to future-proof the code. When your PIL minversion is 9.1 or later, you can easily grep for PIL_LT_9_1 to get rid of unnecessary checks. Is that okay?

ejeschke commented 2 years ago

I'm ok with it, @pllim.

pllim commented 2 years ago

Can we merge then? 😸

ejeschke commented 2 years ago

FFTM

pllim commented 2 years ago

Thanks!