ejeschke / ginga

The Ginga astronomical FITS file viewer
BSD 3-Clause "New" or "Revised" License
120 stars 77 forks source link

restart RC failed #1005

Closed fmadec closed 2 years ago

fmadec commented 2 years ago

I'd like to change the Address of the remote control (to bind on all interface) so I use blank for host so put set Adrr = :9000.

But the restart failed with:

Error making callback 'activated': [Errno 98] Address already in use
Traceback:
  File "/software/conda/envs/conda-ics/lib/python3.7/site-packages/ginga/misc/Callback.py", line 156, in _do_callbacks
    res = method(*cb_args, **cb_kwargs)

  File "/software/conda/envs/conda-ics/lib/python3.7/site-packages/ginga/rv/plugins/RC.py", line 276, in restart_cb
    self.start()

  File "/software/conda/envs/conda-ics/lib/python3.7/site-packages/ginga/rv/plugins/RC.py", line 268, in start
    self.server.start(thread_pool=self.fv.get_threadPool())

  File "/software/conda/envs/conda-ics/lib/python3.7/site-packages/ginga/util/grc.py", line 218, in start
    allow_none=True)

  File "/software/conda/envs/conda-ics/lib/python3.7/xmlrpc/server.py", line 605, in __init__
    socketserver.TCPServer.__init__(self, addr, requestHandler, bind_and_activate)

  File "/software/conda/envs/conda-ics/lib/python3.7/socketserver.py", line 452, in __init__
    self.server_bind()

  File "/software/conda/envs/conda-ics/lib/python3.7/socketserver.py", line 466, in server_bind
    self.socket.bind(self.server_address)
ejeschke commented 2 years ago

@fmadec, can you try latest dev version (commit 608ee585e2d13f8e3a8847f2ab39d9a6ae5e898e)?

I think it may fix this issue.

fmadec commented 2 years ago

it works ! @ejeschke tx

pllim commented 2 years ago

Great to hear! Closing the issue then. 😸