search

ejeschke / ginga

The Ginga astronomical FITS file viewer
BSD 3-Clause "New" or "Revised" License
120 stars 77 forks source link

Fixed a longstanding issue for event handling on a ginga canvas #1013

Closed ejeschke closed 1 year ago

ejeschke commented 1 year ago

Fixed a longstanding issue where events registered on a canvas could be masked by default key/cursor bindings (not associated with a mode). This meant, for example, that only certain keystrokes could be captured by an event handler registered on a ginga canvas, because any keystrokes that had a default binding would take precedence. Now such bindings are only executed if the event is not handled by any active canvas bindings.

ejeschke commented 1 year ago

Looks like our version of flake8 was updated on the CI. I fixed all the new flake8 errors flagged by the CI.

ejeschke commented 1 year ago

@pllim, don't think this should affect anything at all in stginga.

pllim commented 1 year ago

LGTM at a glance. Alas, I don't have time to test this. Feel free to merge. Thanks!